[CHORE] Refactor dependencies, update scalacheck #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmrozek
force-pushed
the
refactor-dependencies
branch
from
f79f14c to
bfc624b
Compare
added 7 commits
September 17, 2020 11:26
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � build.sbt
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � src/test/scala/io/iohk/ethereum/consensus/validators/BlockHeaderValidatorSpec.scala
mirkoAlic
reviewed
Sep 17, 2020
repo.nix
Outdated
| "nix-rocksDb" = ""; | ||
| }; | ||
| "artifacts" = { | ||
| "nix-local-preloaded/file:/Users/mmrozek/.sbtix/preloaded/com/trueaccord/lenses/lenses_2.12/0.4.12/lenses_2.12-0.4.12.jar" = { |
Contributor
|
Fix nix build is still needed, but apart from that, LGTM! |
mirkoAlic
added
the
update dependencies
ntallar
reviewed
Sep 17, 2020
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � build.sbt
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � build.sbt � project/Dependencies.scala � src/test/scala/io/iohk/ethereum/consensus/BlockGeneratorSpec.scala
kapke
approved these changes
Sep 18, 2020
Contributor
kapke
left a comment
kapke
left a comment
There was a problem hiding this comment.
One minor thing and look good to me!
| # is pulled from the corresponding consensus implementation. | ||
| # For example, in case of ethash, a section named `ethash` is used. | ||
| # Available protocols: ethash, mocked | ||
| # In case of mocked, remember to enable qa api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CAUTION: a majority of changes is caused by renaming of
PropertyCheckstrait and formatting all touched files. Please don't be afraid ;)