[ECTM-80] QA Service + mocked miner #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoAlic
reviewed
Sep 15, 2020
| @@ -0,0 +1,3 @@ | |||
| version = "2.3.0" | |||
mirkoAlic
reviewed
Sep 15, 2020
| "org.bouncycastle" % "bcprov-jdk15on" % "1.59", | ||
| "com.typesafe.scala-logging" %% "scala-logging" % "3.9.0", | ||
| "org.typelevel" %% "mouse" % "0.18", | ||
| "org.typelevel" %% "mouse" % "0.23", |
Contributor
There was a problem hiding this comment.
Maybe we could start adding new Dependencies following the approach we use in the other project. (like i started doing it here: https://github.com/input-output-hk/mantis/pull/668/files#diff-fdc3abdfd754eeb24090dbd90aeec2ceR77) WDYT?
Contributor
Author
There was a problem hiding this comment.
Yes, we should do that. I will do that in separate PR
mirkoAlic
reviewed
Sep 15, 2020
| import io.iohk.ethereum.utils.ByteStringUtils | ||
| import scala.concurrent.duration._ | ||
|
|
||
| class MockedMiner( |
mirkoAlic
reviewed
Sep 15, 2020
| import scala.concurrent.ExecutionContext | ||
| import scala.language.higherKinds | ||
|
|
||
| trait SpecBase extends TypeCheckedTripleEquals with DiagrammedAssertions with Matchers { self: AsyncTestSuite => |
Contributor
|
Please update insomnia workspace (Yes we already have one =) ) |
mmrozek
force-pushed
the
ectm-80-qa-service
branch
from
135980a to
e6f714b
Compare
mmrozek
force-pushed
the
ectm-80-qa-service
branch
from
e6f714b to
802632a
Compare
kapke
reviewed
Sep 16, 2020
| @@ -0,0 +1,3 @@ | |||
| version = "2.3.0" | |||
| "com.typesafe.scala-logging" %% "scala-logging" % "3.9.0", | ||
| "org.typelevel" %% "mouse" % "0.18", | ||
| "org.typelevel" %% "mouse" % "0.23", | ||
| "org.typelevel" %% "cats-core" % "2.0.0", |
Contributor
There was a problem hiding this comment.
I'm pretty sure all of them can be bumped up a bit. IIRC Cats - 2.2, Monix 3.2, etc.
| # Available choices are: eth, web3, net, personal, test, daedalus, iele | ||
| apis = "eth,web3,net,personal,daedalus,debug" | ||
| # Available choices are: eth, web3, net, personal, test, daedalus, iele, qa | ||
| apis = "eth,web3,net,personal,daedalus,debug,qa" |
Contributor
There was a problem hiding this comment.
shouldn't section about available consensus/pow algorithms be updated as well?
shouldn't config in universal be updated for sake of documentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description