[ETCM-107] Backport logging configuration #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoAlic
reviewed
Sep 14, 2020
src/main/resources/logback.xml
Outdated
| </else> | ||
| </if> | ||
| <appender-ref ref="FILE" /> | ||
| <appender-ref ref="METRICS" /> |
Contributor
Author
There was a problem hiding this comment.
Not! I did remove appender but forgot to remove ref to it
mirkoAlic
approved these changes
Sep 14, 2020
Contributor
mirkoAlic
left a comment
mirkoAlic
left a comment
There was a problem hiding this comment.
(only one minor comment/doubt) LGTM!
mmrozek
reviewed
Sep 14, 2020
| log-errors = true | ||
| } | ||
|
|
||
| logging { |
Contributor
There was a problem hiding this comment.
Shouldn't we expose this config in the universal folder also? Maybe the file logging.conf will be useful.
kapke
force-pushed
the
etcm-107-backport-logging-configuration
branch
2 times, most recently
from
94797d5 to
e1a6002
Compare
kapke
force-pushed
the
etcm-107-backport-logging-configuration
branch
from
e1a6002 to
ab4348f
Compare
kapke
force-pushed
the
etcm-107-backport-logging-configuration
branch
from
ab4348f to
4004d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport Logging configuration to allow:
Important changes introduced
This PR changes logging configuration in a way that may affect deployments. How can I check whether that's true?
Testing
mantis.logging