[FIX] fast sync fix #652
Merged
[FIX] fast sync fix #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoAlic
reviewed
Sep 16, 2020
| // We could end in wrong fork and get blocked so we should rewind our state a little | ||
| // we blacklist peer just in case we got malicious peer which would send us bad blocks, forcing us to rollback | ||
| // to genesis | ||
| log.info("Parent difficulty not found for block {}, not processing rest of headers", header.idTag) |
Contributor
There was a problem hiding this comment.
maybe all this logs that end up in a blacklisting action could be used .warn instead of info, in that way we could easily search for them. WDYT?
mirkoAlic
reviewed
Sep 16, 2020
| log.debug("Parent difficulty not found for block {}, not processing rest of headers", header.number) | ||
| processSyncing() | ||
| // We could end in wrong fork and get blocked so we should rewind our state a little | ||
| // we blacklist peer just in case we got malicious peer which would send us bad blocks, forcing us to rollback |
Contributor
There was a problem hiding this comment.
sounds hardcore..i mean, we blacklist the Peer. but still we rewind to genesis? =S
Contributor
Author
There was a problem hiding this comment.
if we blacklist this peer and rewind state a little, we hopefully will get some blocks from other peer which will steer us to main chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.