[ETCM-19] chainId opcode #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KonradStaniec
left a comment
KonradStaniec
left a comment
There was a problem hiding this comment.
I would add at least one unit test maybe in OpCodeFunSpec ?
| opCodeList = AghartaOpCodes | ||
| ) | ||
|
|
||
| val PhoenixConfigBuilder: EvmConfigBuilder = config => PhoenixConfigBuilder(config).copy( |
Contributor
There was a problem hiding this comment.
Here it shoud be:
val PhoenixConfigBuilder: EvmConfigBuilder = config => AghartaConfigBuilder(config).copy(
mmrozek
force-pushed
the
etcm-19-chainid-opcode
branch
from
f38353b to
2136f9b
Compare
Contributor
Author
|
@KonradStaniec, There is a generic test for all |
Contributor
|
ok, but then from what I see it uses byzantium config https://github.com/input-output-hk/mantis/blob/etcm-19-chainid-opcode/src/test/scala/io/iohk/ethereum/vm/OpCodeFunSpec.scala#L17, to use it we would need change this to phoenix conifg ? |
KonradStaniec
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-1344: ChainID opcode