Skip to content

Conversation

@mmrozek
Copy link
Contributor

@mmrozek mmrozek commented Aug 25, 2020

Changes related to Petersburg fork

@mmrozek mmrozek requested a review from KonradStaniec August 25, 2020 12:43
@mmrozek mmrozek force-pushed the etcm-28-petersbug-changes branch from 64e5bc1 to 9b1bb44 Compare August 25, 2020 13:42
Base automatically changed from etcm-25-enable-features to phase/etc_forks August 25, 2020 14:49
…mantis into etcm-28-petersbug-changes

� Conflicts:
�	src/main/scala/io/iohk/ethereum/extvm/VMServer.scala
�	src/main/scala/io/iohk/ethereum/vm/BlockchainConfigForEvm.scala
�	src/main/scala/io/iohk/ethereum/vm/EvmConfig.scala
�	src/main/scala/io/iohk/ethereum/vm/VM.scala
�	src/test/scala/io/iohk/ethereum/extvm/VMClientSpec.scala
�	src/test/scala/io/iohk/ethereum/vm/Fixtures.scala
�	src/test/scala/io/iohk/ethereum/vm/VMSpec.scala

# Petersburg fork block number (ETH only)
# https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1716.md
petersburg-block-number = "7280000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm mayble as we are adding it, we should also change constantinople fork block number in config to 7280000 ? (https://media.consensys.net/the-constantinople-hard-fork-what-you-need-to-know-d438a91dec3f)

@mmrozek mmrozek force-pushed the etcm-28-petersbug-changes branch from e97a040 to 9f7977b Compare August 26, 2020 07:44
…ttps://github.com/input-output-hk/mantis into etcm-28-petersbug-changes

� Conflicts:
�	src/main/scala/io/iohk/ethereum/extvm/VMServer.scala
�	src/main/scala/io/iohk/ethereum/vm/BlockchainConfigForEvm.scala
�	src/main/scala/io/iohk/ethereum/vm/EvmConfig.scala
�	src/test/scala/io/iohk/ethereum/extvm/VMClientSpec.scala
�	src/test/scala/io/iohk/ethereum/vm/Fixtures.scala
�	src/test/scala/io/iohk/ethereum/vm/VMSpec.scala
@mmrozek mmrozek merged commit c153333 into phase/etc_forks Aug 26, 2020
@mmrozek mmrozek deleted the etcm-28-petersbug-changes branch August 26, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants