[ETCM-1060] rewrite ommers validation to avoid using getBlockByNumber #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienRichez
force-pushed
the
refactor/ETCM-1060-rewrite-ommers-validation
branch
from
63d33ed to
f533ddf
Compare
leo-bogastry
approved these changes
Aug 3, 2021
strauss-m
reviewed
Aug 3, 2021
src/main/scala/io/iohk/ethereum/consensus/pow/validators/OmmersValidator.scala
Show resolved
Hide resolved
strauss-m
reviewed
Aug 3, 2021
src/main/scala/io/iohk/ethereum/consensus/pow/validators/OmmersValidator.scala
Show resolved
Hide resolved
strauss-m
reviewed
Aug 3, 2021
src/main/scala/io/iohk/ethereum/consensus/pow/validators/OmmersValidator.scala
Outdated
Show resolved
Hide resolved
strauss-m
reviewed
Aug 3, 2021
| val blocks = | ||
| (numbers.toList.flatMap(nb => bestBranch.getBlockByNumber(nb)) :+ block) ::: queuedBlocks | ||
| blocks | ||
| val remainingBlocks = Iterator |
Contributor
There was a problem hiding this comment.
same remarks as in OmmersValidation
AurelienRichez
force-pushed
the
refactor/ETCM-1060-rewrite-ommers-validation
branch
from
f533ddf to
a245a6b
Compare
strauss-m
approved these changes
Aug 4, 2021
AurelienRichez
force-pushed
the
refactor/ETCM-1060-rewrite-ommers-validation
branch
from
a245a6b to
22f0cd9
Compare
AurelienRichez
force-pushed
the
refactor/ETCM-1060-rewrite-ommers-validation
branch
from
22f0cd9 to
c0a5315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rewrites
getNBlocksBackin OmmersValidation so that it does not usegetBlockByNumber.getBlockByNumberare out of the core flow of mantis (json rpc calls). This means that it opens a path to be able to switch the best branch just by changing a hash in the storage, and having the block number mapping built somewhere else. We can insert new blocks without rebuilding the index each time.