[ETCM-980] restore json OptionNoneToNullSerializer #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 357bc89 regarding OptionNoneToNullSerializer.
strauss-m
force-pushed
the
bugfix/ETCM-980_json_regression
branch
from
47f1a81 to
948c0f0
Compare
leo-bogastry
approved these changes
Jul 22, 2021
AnastasiiaL
approved these changes
Jul 23, 2021
jvdp
approved these changes
Jul 23, 2021
AurelienRichez
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 357bc89 regarding OptionNoneToNullSerializer.
Description
ERC20 tests are not working anymore after ETCM-980 merge
Proposed Solution
This is due to the removal of OptionNoneToNullSerializer
Testing
Both ETCM-980 related tests and ERC-20 tests are passing