Skip to content

[ETCM-1014] retesteth: 0.1.0 → 0.1.1 #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2021
Merged

[ETCM-1014] retesteth: 0.1.0 → 0.1.1 #1062

merged 2 commits into from
Jul 13, 2021

Conversation

@nrdxp
Copy link
Contributor

@nrdxp nrdxp commented Jul 13, 2021

I force pushed a rebase on our retesteth fork with an update to the latest version, as well as some simple fixups to get it building. This updates the package definition to build this new version.

@jvdp
Copy link
Contributor

jvdp commented Jul 13, 2021

I force pushed a rebase on our retesteth fork with an update to the latest version, as well as some simple fixups to get it building. This updates the package definition to build this new version.

Do you think it would be complicated to enable/disable hunter with a flag? Then we might upstream the changes.

@nrdxp
Copy link
Contributor Author

nrdxp commented Jul 13, 2021 •
edited
Loading

Do you think it would be complicated to enable/disable hunter with a flag? Then we might upstream the changes.

The only change is to remove hunter and use pkg-config instead, so there would be nothing to upstream. We tried making hunter work originally by simply toggling it off, but that wasn't enough, and nothing we tried worked except removing it completely.

@jvdp
Copy link
Contributor

jvdp commented Jul 13, 2021

The only change is to remove hunter and use pkg-config instead, so there would be nothing to upstream. We tried making hunter work originally by simply toggling it off, but that wasn't enough, and nothing we tried worked except removing it completely.

Ahh ok, so pretty complicated. Too bad.

@nrdxp nrdxp merged commit 6286011 into develop Jul 13, 2021
@nrdxp nrdxp deleted the update-retesteth branch July 13, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzajkowski dzajkowski dzajkowski approved these changes

+1 more reviewer

@jvdp jvdp jvdp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nrdxp @jvdp @dzajkowski