Skip to content

[ETCM-355] Refactor capabilities #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 14, 2021
Merged

[ETCM-355] Refactor capabilities #1060

merged 7 commits into from
Jul 14, 2021

Conversation

@lukasz-golebiewski
Copy link
Contributor

@lukasz-golebiewski lukasz-golebiewski commented Jul 13, 2021

Description

Another refactoring promised in #1030 (comment)
Makes unsupported capabilities unrepresentable at the type level

dzajkowski
dzajkowski approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@dzajkowski dzajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasz-golebiewski lukasz-golebiewski force-pushed the refactor/etcm-355/capabilities branch from 7f4cdb1 to 81621a2 Compare July 13, 2021 11:47
@lukasz-golebiewski lukasz-golebiewski force-pushed the refactor/etcm-355/capabilities branch from 36aa38c to e92d0a9 Compare July 14, 2021 07:20
@jvdp
Copy link
Contributor

jvdp commented Jul 14, 2021 •
edited
Loading

Makes unsupported capabilities unrepresentable at the type level

Can you expand on this a bit?

Also, from the original comment:

would be so cool to have this fail if a new block type is introduced. just a thought, no great ideas.

What does this failure look like?

@lukasz-golebiewski
Copy link
Contributor Author

lukasz-golebiewski commented Jul 14, 2021

Makes unsupported capabilities unrepresentable at the type level

Can you expand on this a bit?

Also, from the original comment:

would be so cool to have this fail if a new block type is introduced. just a thought, no great ideas.

What does this failure look like?

Clarified in a call

jvdp
jvdp approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@jvdp jvdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasz-golebiewski lukasz-golebiewski merged commit 66c1920 into develop Jul 14, 2021
@lukasz-golebiewski lukasz-golebiewski deleted the refactor/etcm-355/capabilities branch July 14, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzajkowski dzajkowski dzajkowski approved these changes

+1 more reviewer

@jvdp jvdp jvdp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukasz-golebiewski @jvdp @dzajkowski