[ETCM-1001] Rename consensus classes to mining #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-golebiewski
approved these changes
Jul 12, 2021
leo-bogastry
force-pushed
the
refactor/ETCM-1001-rename-consensus-to-mining
branch
2 times, most recently
from
5add5d8 to
d6cada0
Compare
dzajkowski
reviewed
Jul 13, 2021
| "targets": [ | ||
| { | ||
| "expr": "rate(app_consensus_blocks_generate_timer_seconds_sum[$__rate_interval])/rate(app_consensus_blocks_generate_timer_seconds_count[$__rate_interval])", | ||
| "expr": "rate(app_mining_blocks_generate_timer_seconds_sum[$__rate_interval])/rate(app_mining_blocks_generate_timer_seconds_count[$__rate_interval])", |
Contributor
There was a problem hiding this comment.
please remember to notify @nrdxp so that they have a chance to update the ops dashboards.
Contributor
Author
There was a problem hiding this comment.
I checked the dashboards on mantis-ops and they don't use this metric, but I did open a PR to fix the deployment input-output-hk/mantis-ops#51
leo-bogastry
force-pushed
the
refactor/ETCM-1001-rename-consensus-to-mining
branch
from
d6cada0 to
6d2f61b
Compare
strauss-m
reviewed
Jul 15, 2021
leo-bogastry
force-pushed
the
refactor/ETCM-1001-rename-consensus-to-mining
branch
from
6d2f61b to
a08bff9
Compare
strauss-m
approved these changes
Jul 15, 2021
added 21 commits
July 15, 2021 14:55
…hat instantiate it)
…iables that instantiate it)
leo-bogastry
force-pushed
the
refactor/ETCM-1001-rename-consensus-to-mining
branch
from
a08bff9 to
5f1f926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames classes that are called Consensus* but that in fact focus on Mining
Proposed Solution
The code base has some classes called Consensus, ConsensusBuilder, ConsensusConfig, ... but these do not implement the features that the new architecture understands that should be implemented by the Consensus layer, but rather focus on mining and block generation.
In order to allow the implementation of the desired Consensus layer the current one needs to be renamed.
Testing:
I have successfully connected to ETC
It is currently deployed in Staging, it need a PR to me merged because of the rename in base.conf input-output-hk/mantis-ops#51