[ETCM-355] Refactor messages decoding #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-golebiewski
force-pushed
the
refactoring/etcm-355
branch
3 times, most recently
from
9146a3b to
8dc8007
Compare
dzajkowski
approved these changes
Jul 12, 2021
lukasz-golebiewski
changed the title
Rename old implementation to fromBytesUnsafe
lukasz-golebiewski
force-pushed
the
refactoring/etcm-355
branch
from
8dc8007 to
32e9f48
Compare
leo-bogastry
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a post merge refactoring promised in #1030 (comment)