Skip to content

Conversation

@leo-bogastry
Copy link
Contributor

Description

Remove method saveNode from Blockchain class and use StateStorage directly

Proposed Solution

The method "saveNode" just makes a direct call to the StateStorage and is only in a few places

The code was modified to have the StateStorage called directly

@leo-bogastry leo-bogastry force-pushed the refactor/ETCM-985-saveNode branch 2 times, most recently from 7d49542 to 634c78b Compare July 8, 2021 08:42
@leo-bogastry leo-bogastry force-pushed the refactor/ETCM-985-saveNode branch from 634c78b to 3a4a006 Compare July 8, 2021 10:08
Copy link
Contributor

@jvdp jvdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leo-bogastry leo-bogastry merged commit f97c6bf into develop Jul 9, 2021
@leo-bogastry leo-bogastry deleted the refactor/ETCM-985-saveNode branch July 9, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants