Add extra info data from JsonRpcErrors to the log #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzajkowski
approved these changes
Jun 24, 2021
AnastasiiaL
approved these changes
Jun 24, 2021
Contributor
|
could you mark the commit as [Kaizen]? it's easier to categorise the commits when building a release log? |
Contributor
Author
Good idea 👍 |
leo-bogastry
force-pushed
the
feature/improve-log
branch
from
6d7492f to
c6a9a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the JSON RPC API logs errors, the
data: Option[JValue]is not being logged. Given that the same error can happen for more than one reason, this is good information