[ETCM-841] Consume remaining data when extracting Hello in order #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzajkowski
force-pushed
the
bugfix/etcm-841-consume-remaining-data-in-order
branch
from
ea50d69 to
b395772
Compare
AnastasiiaL
approved these changes
Jun 21, 2021
src/main/scala/io/iohk/ethereum/network/rlpx/RLPxConnectionHandler.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/iohk/ethereum/network/rlpx/RLPxConnectionHandler.scala
Show resolved
Hide resolved
lukasz-golebiewski
approved these changes
Jun 21, 2021
dzajkowski
force-pushed
the
bugfix/etcm-841-consume-remaining-data-in-order
branch
from
687b785 to
4c300d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameCodec holds Secrets which is a mutable structure. The unfortunate reality is that it cannot identify that it is reading a message out of order. This goes exactly in opposite to how akka actors handle messages and can cause Frame deserialization to throw a "MAC mismatch" exception.
The fix is to cause the FrameCodec to read any available data immediately and not reschedule it to a mailbox.