[ETCM-940] remove get transaction location from blockchain #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienRichez
force-pushed
the
refactor/ETCM-940-remove-getTransactionLocation
branch
2 times, most recently
from
5ff8d17 to
4b78f28
Compare
lukasz-golebiewski
approved these changes
Jun 18, 2021
leo-bogastry
approved these changes
Jun 21, 2021
added 4 commits
June 21, 2021 09:19
it is used only by EthTxService so EthTxService can directly use the storage
AurelienRichez
force-pushed
the
refactor/ETCM-940-remove-getTransactionLocation
branch
from
3b3e6c4 to
72255f5
Compare
AurelienRichez
deleted the
refactor/ETCM-940-remove-getTransactionLocation
branch
krzysztofpaliga-iohk
pushed a commit
that referenced
this pull request
Jun 21, 2021
* remove unused blockchain parameters * remove getTransactionLocation from blockchain it is used only by EthTxService so EthTxService can directly use the storage * remove getChainWeightByNumber as it is unused * remove getStateStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of the effort to simplify and reduce dependencies on blockchain. As a first small step, this removes
getTransactionLocationwhich is used only once and other unused parameters.Each commit is a small change so they can be reviewed separately (and reverted separately easily if there are not considered useful)