Feature/etcm 910 change modexp cost calculation #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/scala/io/iohk/ethereum/vm/PrecompiledContractsSpec.scala
Outdated
Show resolved
Hide resolved
AurelienRichez
approved these changes
Jun 21, 2021
AnastasiiaL
approved these changes
Jun 22, 2021
| val expHead = | ||
| if (expLength <= lengthBytes) | ||
| expBytes.padToByteString(expLength, 0.toByte) | ||
| private def getMultComplexity(x: BigInt): BigInt = { |
Contributor
There was a problem hiding this comment.
maybe a comment explaining all those numbers? I wouldn't know how to change that piece because I don't know where all those numbers are coming from
Contributor
Author
There was a problem hiding this comment.
hence the name of the object (PostEIP198Cost). I can quote the EIP but I think this is too complex to just explain away in a comment - it needs to be read at the source. I'll add a link to the EIPs though.
dzajkowski
force-pushed
the
feature/etcm-910-change-modexp-cost-calculation
branch
from
31f1f47 to
8f29db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModExp cost calculation change and guard on current fork.