[ETCM-893] Add support for chains with ids bigger than 127 #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienRichez
approved these changes
Jun 3, 2021
AnastasiiaL
reviewed
Jun 4, 2021
src/test/scala/io/iohk/ethereum/network/p2p/messages/NewBlockSpec.scala
Outdated
Show resolved
Hide resolved
AnastasiiaL
approved these changes
Jun 4, 2021
leo-bogastry
force-pushed
the
bugfix/ETCM-893-support-bigger-chainids
branch
from
71d59d3 to
4551213
Compare
dzajkowski
added a commit
that referenced
this pull request
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Mantis only supports networks id a chaind id up to 127.
This brought problems syncing with Astor, that has a chainid of 212
Proposed Solution
Blockchain config, chainid field from Byte to BigInt
ECDSASignature, v field from Byte to BigInt
Testing
Synchronization with ETC, Sagano and Astor were successfull
On a private network (network id = 2 / chain id = 61) a new tx was created, included in a block and successfully propagated