Skip to content

fix(extension): translation keys casing and unit tests #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(extension): translation keys casing and unit tests #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...s/dapp/components/confirm-transaction/__tests__/ConfirmDRepRegistrationContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,12 @@ describe('Testing ConfirmDRepRegistrationContainer component', () => {
url: certificate.anchor?.url
},
translations: {
metadata: t('core.drepRegistration.metadata'),
metadata: t('core.DRepRegistration.metadata'),
labels: {
depositPaid: t('core.drepRegistration.depositPaid'),
drepId: t('core.drepRegistration.drepId'),
hash: t('core.drepRegistration.hash'),
url: t('core.drepRegistration.url')
depositPaid: t('core.DRepRegistration.depositPaid'),
drepId: t('core.DRepRegistration.drepId'),
hash: t('core.DRepRegistration.hash'),
url: t('core.DRepRegistration.url')
}
},
errorMessage
Expand Down
10 changes: 5 additions & 5 deletions ...res/dapp/components/confirm-transaction/__tests__/ConfirmDRepRetirementContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ describe('Testing ConfirmDRepRetirementContainer component', () => {
drepId: Cardano.DRepID(HexBlob.toTypedBech32('drep', Wallet.HexBlob(certificate.dRepCredential.hash)))
},
translations: {
metadata: t('core.drepRetirement.metadata'),
metadata: t('core.DRepRetirement.metadata'),
labels: {
depositReturned: t('core.drepRetirement.depositReturned'),
drepId: t('core.drepRetirement.drepId')
depositReturned: t('core.DRepRetirement.depositReturned'),
drepId: t('core.DRepRetirement.drepId')
}
},
errorMessage
Expand All @@ -198,7 +198,7 @@ describe('Testing ConfirmDRepRetirementContainer component', () => {
expect(queryByTestId('ConfirmDRepRetirementContainer')).toBeInTheDocument();
expect(
mockConfirmDRepRetirement.mock.calls[mockConfirmDRepRetirement.mock.calls.length - 1][0].errorMessage
).toEqual(t('core.drepRetirement.isOwnRetirement'));
).toEqual(t('core.DRepRetirement.isOwnRetirement'));
});

test('should render ConfirmDRepRetirementContainer component with proper error for not own retirement', async () => {
Expand All @@ -215,6 +215,6 @@ describe('Testing ConfirmDRepRetirementContainer component', () => {

expect(
mockConfirmDRepRetirement.mock.calls[mockConfirmDRepRetirement.mock.calls.length - 1][0].errorMessage
).toEqual(t('core.drepRetirement.isNotOwnRetirement'));
).toEqual(t('core.DRepRetirement.isNotOwnRetirement'));
});
});
8 changes: 4 additions & 4 deletions ...eatures/dapp/components/confirm-transaction/__tests__/ConfirmDRepUpdateContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,11 @@ describe('Testing ConfirmDRepUpdateContainer component', () => {
url: certificate.anchor?.url
},
translations: {
metadata: t('core.drepUpdate.metadata'),
metadata: t('core.DRepUpdate.metadata'),
labels: {
drepId: t('core.drepUpdate.drepId'),
hash: t('core.drepUpdate.hash'),
url: t('core.drepUpdate.url')
drepId: t('core.DRepUpdate.drepId'),
hash: t('core.DRepUpdate.hash'),
url: t('core.DRepUpdate.url')
}
},
errorMessage
Expand Down
10 changes: 5 additions & 5 deletions ...res/dapp/components/confirm-transaction/__tests__/ConfirmVoteDelegationContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ describe('Testing ConfirmVoteDelegationContainer component', () => {
)
},
translations: {
metadata: t('core.voteDelegation.metadata'),
option: t('core.voteDelegation.option'),
metadata: t('core.VoteDelegation.metadata'),
option: t('core.VoteDelegation.option'),
labels: {
drepId: t('core.voteDelegation.drepId'),
alwaysAbstain: t('core.voteDelegation.alwaysAbstain'),
alwaysNoConfidence: t('core.voteDelegation.alwaysNoConfidence')
drepId: t('core.VoteDelegation.drepId'),
alwaysAbstain: t('core.VoteDelegation.alwaysAbstain'),
alwaysNoConfidence: t('core.VoteDelegation.alwaysNoConfidence')
}
},
errorMessage
Expand Down
18 changes: 9 additions & 9 deletions ...features/dapp/components/confirm-transaction/__tests__/VotingProceduresContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,19 +230,19 @@ describe('Testing VotingProceduresContainer component', () => {
}))
})),
translations: {
voterType: t('core.votingProcedures.voterType'),
procedureTitle: t('core.votingProcedures.procedureTitle'),
actionIdTitle: t('core.votingProcedures.actionIdTitle'),
vote: t('core.votingProcedures.vote'),
voterType: t('core.VotingProcedures.voterType'),
procedureTitle: t('core.VotingProcedures.procedureTitle'),
actionIdTitle: t('core.VotingProcedures.actionIdTitle'),
vote: t('core.VotingProcedures.vote'),
actionId: {
index: t('core.votingProcedures.actionId.index'),
txHash: t('core.votingProcedures.actionId.txHash')
index: t('core.VotingProcedures.actionId.index'),
txHash: t('core.VotingProcedures.actionId.txHash')
},
anchor: {
hash: t('core.votingProcedures.anchor.hash'),
url: t('core.votingProcedures.anchor.url')
hash: t('core.VotingProcedures.anchor.hash'),
url: t('core.VotingProcedures.anchor.url')
},
dRepId: t('core.votingProcedures.dRepId')
dRepId: t('core.VotingProcedures.dRepId')
},
errorMessage
},
Expand Down
4 changes: 2 additions & 2 deletions ...xtension-wallet/src/features/dapp/components/confirm-transaction/__tests__/utils.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ describe('Testing utils', () => {

test('testing getOwnRetirementMessageKey', () => {
expect(getOwnRetirementMessageKey(undefined)).toEqual('');
expect(getOwnRetirementMessageKey(true)).toEqual('core.drepRetirement.isOwnRetirement');
expect(getOwnRetirementMessageKey(false)).toEqual('core.drepRetirement.isNotOwnRetirement');
expect(getOwnRetirementMessageKey(true)).toEqual('core.DRepRetirement.isOwnRetirement');
expect(getOwnRetirementMessageKey(false)).toEqual('core.DRepRetirement.isNotOwnRetirement');
});
});
2 changes: 1 addition & 1 deletion apps/browser-extension-wallet/src/features/dapp/components/confirm-transaction/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,5 @@ export const getOwnRetirementMessageKey = (isOwnRetirement: boolean | undefined)
if (isOwnRetirement === undefined) {
return '';
}
return isOwnRetirement ? 'core.drepRetirement.isOwnRetirement' : 'core.drepRetirement.isNotOwnRetirement';
return isOwnRetirement ? 'core.DRepRetirement.isOwnRetirement' : 'core.DRepRetirement.isNotOwnRetirement';
};