Skip to content

Conversation

@DominikGuzei
Copy link
Member

@DominikGuzei DominikGuzei commented Nov 23, 2023

Checklist

Please note: this PR is based on #742 which needs to be merged first.


This PR implements the account item components for the new multi-wallet menu.

  • Adds a mock UI without real data
  • Also adds a new control button variant for extra small, purple version

Screenshots

image
image

Videos

The mocked accounts list UI in action:

Monosnap.screencast.2023-11-24.13-40-05.mp4

@DominikGuzei DominikGuzei self-assigned this Nov 23, 2023
@github-actions github-actions bot added the browser Changes to the browser application. label Nov 23, 2023
@DominikGuzei DominikGuzei marked this pull request as ready for review November 24, 2023 13:32
@DominikGuzei DominikGuzei requested review from a team as code owners November 24, 2023 13:32
@github-actions
Copy link

github-actions bot commented Nov 24, 2023

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 8305fddf

passed failed skipped flaky total result
Total 31 0 0 0 31

@coveralls
Copy link

coveralls commented Nov 24, 2023

Coverage Status

coverage: 53.21% (-0.04%) from 53.248%
when pulling 8305fdd on feat/lw-9029-account-management-components
into f7c4fd1 on main.

@DominikGuzei DominikGuzei changed the base branch from main to lw-9028-wallet-menu November 27, 2023 13:06
@DominikGuzei DominikGuzei requested review from a team as code owners November 27, 2023 13:06
@github-actions github-actions bot added e2e Changes to the e2e testing instrumentation. ci CI related issues or pull requests. labels Nov 27, 2023
@DominikGuzei
Copy link
Member Author

DominikGuzei commented Nov 27, 2023

@renanvalentin I changed the base branch to your PR which simplifies review because your changes will not be included anymore. In order to make this PR even easier to review, we need to update #742 to latest main branch (otherwise these changes show up here)

Base automatically changed from lw-9028-wallet-menu to main November 29, 2023 13:41
@github-actions github-actions bot removed e2e Changes to the e2e testing instrumentation. ci CI related issues or pull requests. labels Nov 30, 2023
@DominikGuzei
Copy link
Member Author

@renanvalentin @lucas-barros PR updated to latest main and double checked from my side 👍

Copy link
Contributor

@renanvalentin renanvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also, chromatic didn't show up any regression. great job @DominikGuzei

@ljagiela
Copy link
Contributor

ljagiela commented Dec 1, 2023

@DominikGuzei

  • I am unable to scroll the list in the popup view.
  • The unlock button has no hover effect
  • Unlock caption on Unlock button should start with capital "U" (?)
  • Shouldn't the list item have hover effect (eg similar to the one that we have in user menu)
  • When I open accounts menu, account numbers are displayed with 1-2s delay (circle bubbles are empty for a moment)
  • Account menu width is 291px but in figma it's 258px (It looks to me it should have the same width as user menu ?)

@DominikGuzei
Copy link
Member Author

@DominikGuzei

  • I am unable to scroll the list in the popup view.
  • The unlock button has no hover effect
  • Unlock caption on Unlock button should start with capital "U" (?)
  • Shouldn't the list item have hover effect (eg similar to the one that we have in user menu)
  • When I open accounts menu, account numbers are displayed with 1-2s delay (circle bubbles are empty for a moment)
  • Account menu width is 291px but in figma it's 258px (It looks to me it should have the same width as user menu ?)

@ljagiela the following issues have been fixed:

  • list is scrollable
  • list width is 258px
  • unlock button says "Unlock" (uppercase)
  • The hover effects of the unlock button needs to be clarified with design because in Figma the hover shadow is also barely visible (same as implemented)
  • account numbers are displayed immediately

@DominikGuzei DominikGuzei changed the title Create Account management components [LW-9029] feat(extension) Create Account management components [LW-9029] Dec 13, 2023
@DominikGuzei DominikGuzei force-pushed the feat/lw-9029-account-management-components branch from 265dd30 to 8305fdd Compare December 13, 2023 21:28
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DominikGuzei DominikGuzei merged commit a6977f7 into main Dec 13, 2023
@DominikGuzei DominikGuzei deleted the feat/lw-9029-account-management-components branch December 13, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser Changes to the browser application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants