impl Arbitrary for private VoteTally #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
approved these changes
Aug 31, 2021
Contributor
|
Looks good, but the tests detect a format discrepancy: "Error: deserialization: Structure invalid: transaction payload is invalid" |
Contributor
Author
That's the error we were having in production, this branch does not contain the fix for it |
zeegomo
force-pushed
the
vote-tally-tests
branch
from
e90962d to
9181878
Compare
Contributor
Author
|
This was initially put on hold for #655, but since that is not top priority currently I would suggest we merge this to increase coverage and update the proptest PR when needed cc @eugene-babichenko |
Mr-Leshiy
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
Arbitraryimplementation for a privateVoteTally, which, apart from adding tests for a transaction that was not covered before, also allows us to stress very big (i.e. > 64Kib) payloads.We may even think of switching to proptest, but it would mean moving out all of the current tests, which is likely to take quite some time.