add explicit spending counter to account transaction inputs #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added Display implementation for account identifier.
6 tasks
Contributor
|
Closing this for now, we have #571 and more upcoming changes in the works to enable more flexible ordering of transactions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for reordering transactions that were submitted out of the expected order.
The thing that is very debatable in this approach is that currently it introduces 4 bytes for each input that are going to be unused by UTXO inputs. This is by no means a good design and needs to be implemented in a less wasteful way. But good enough for the purpose of demonstrating the approach.