Force networkId on pool reward accounts #310
Merged
+43
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One early SPO used a testnet address (e0...) as its reward account, and registered the same hash on mainnet (e1...). It still got its reward in epoch 211 so this must have been accepted!
SupernaviX
approved these changes
Oct 28, 2025
lowhung
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One early SPO used a testnet address (e0...) as its reward account, and registered the same hash on mainnet (e1...). It still got its reward in epoch 211 so this must have been accepted! Previously we ignored the network Id for comparison/mapping, but since we switched to StakeAddress everywhere, this broke.
This PR forces the network ID in map_parameters(), and adds a bunch of debug. Note that StakeAddresses are now Display'ed including the leading network/type byte, which would have made this easier to find!