Don't debit deposits pot twice on stake refund (#299) #302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line deletion! Fixes #299
This is an interesting one - it turns out although there was the mechanism to post stake refunds to the end of epoch, it was never actually actioned until @lowhung rightly added it in 497214e:
So we were previously only debiting the deposits pot, but not actually paying to the reward account - but adding this meant debiting the pot twice, but does pay the reward. So we gained one, lost one. Now we gain both :-)