-
Notifications
You must be signed in to change notification settings - Fork 5
Allow offline compilation and --config <PATH>
#254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow offline compilation and --config <PATH>
#254
Conversation
You reference a JSON file with the `ACROPOLIS_OFFLINE_MIRROR` environment variable. Each key is an URL that the `build.rs` scripts would normally download. Each value is its contents. If the variable or keys are not set, it downloads as usual. But people compiling without Internet access, can still do so by providing their own pre-downloaded overrides.
…e time If you set `ACROPOLIS_OMNIBUS_DEFAULT_CONFIG` during compilation, this value will be used as the default, allowing build systems to override the default default of `omnibus.toml`.
19cbf24 to
180e10f
Compare
build.rs overrides--config <PATH>
processes/replayer/src/main.rs
Outdated
|
|
||
| #[derive(Debug, clap::Parser)] | ||
| #[command( | ||
| name = "acropolis_process_omnibus", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong process name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry – fixed in 1962198.
|
This is unexpected but most welcome, thanks @michalrus! Very useful - we can use this for dev configs and prevent ourselves from accidentally committing modified versions, too! |
|
@sandtreader thanks! I thought that maybe it'd make more sense for the |
Done in 976793e. |
Context
Offline compilation
ACROPOLIS_OFFLINE_MIRRORenvironment variable.build.rsscripts would normally download.Specifying
--config <FILE>--config <FILE>argument, and that file will be used.ACROPOLIS_OMNIBUS_DEFAULT_CONFIGduring compilation, this value will be used as the default, allowing build systems to override the default default ofomnibus.toml.replayer.tomlandACROPOLIS_REPLAYER_DEFAULT_CONFIG.