Force zero spaces after Not operator #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
antonioeatgoat
changed the title
gmazzap
approved these changes
Jun 28, 2024
tfrommen
reviewed
Jun 28, 2024
Chrico
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
New rule is added to the ruleset.
What is the current behavior?
Both
!$variableand! $variablepass the check.What is the new behavior?
Only
!$variablepass the check.Does this PR introduce a breaking change?
No.
Other information:
I used the rule from PHP_CodeSniffer itself and not the one from Slevomat as suggested in the issue. I realized that the one from Slevomat was actually checking for
-instead of!, and anyway there was no reason for not using this existing one.