[In Progress] Modernize to PHP 8 WPCS 3 #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently `getDeclarationName` will never support T_FN.
The feature branch we were using has been merged.
This was
linked to
issues
Aug 28, 2023
bueltge
approved these changes
Aug 29, 2023
Chrico
approved these changes
Aug 29, 2023
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
See:
In a nutshell, make compatible with PHP 8+and its features and WPCS 3
What is the new behavior (if this is a feature change)?
Dependencies are updated, compatibility improved. Still work to do to cover all modern PHP 8 things.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes.
Other information:
The target
version/2branch will be the branch used to release the new major.