Skip to content

Array(Protocol): rename __getitem__ parameter #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Array(Protocol): rename __getitem__ parameter #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55ac7a4
Array(Protocol): rename __getitem__ parameter
matthiasdiener Aug 26, 2025
e2244d4
try positional only
matthiasdiener Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arraycontext/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def dtype(self) -> np.dtype[Any]:
# If you'd like to see how, try changing the Any to
# AxisIndex = slice | int | "Array"
# Index = AxisIndex |tuple[AxisIndex]
def __getitem__(self, index: Any) -> Array: # pyright: ignore[reportAny]
def __getitem__(self, /, key: object) -> Array:
...

# Some basic arithmetic that's supposed to work
Expand Down
Loading