Skip to content

Conversation

@alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Dec 16, 2021

Seems like the new version of mypy is looking into the singledispatch arguments a bit more closely. The issue was that

  • the base serialize_container took an ArrayContainer (which is an actual class)
  • the ndarray version took an ndarray (which is not a subclass of ArrayContainer!)

This just sets it to Any so that it's a proper fallback for all objects.

Fixes #130

@inducer inducer merged commit c014adb into inducer:main Dec 16, 2021
@inducer
Copy link
Owner

inducer commented Dec 16, 2021

Thanks!

@alexfikl alexfikl deleted the fix-mypy branch December 16, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failing in mypy

2 participants