[Fix] extensions/importType: fix isScoped treating @/abc as scoped module
#2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Jul 8, 2021
aladdin-add
approved these changes
Jul 8, 2021
ljharb
approved these changes
Aug 3, 2021
ljharb
force-pushed
the
origin/fix-is-scoped
branch
from
cc1d442 to
00d7bc8
Compare
ljharb
changed the title
extensions/importType: fix isScoped treating @/abc as scoped module
|
@ljharb With this change, |
|
Yes, because it was a bug that it was treated as a valid package name in the first place. You can configure it with an import resolver. |
|
Hmm. |
|
You’re right, that seems like a bug in the order rule - it should probably use the resolver to get the type. Can you file a new issue for that? |
|
Thank you very much. I created #2249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2145