Make time optional for Trackers #185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes time from baseHeaders and RecordRow. This removes the dependency on Unity API in the base class, which allows RecordRow to be called outside the main tread. It also allows for non-time-based Trackers (e.g. frame count or event based). For the provided prototypes MouseScreenTracker, MouseWorldTracker and PositionRotationTracker, the timestamp is added in GetCurrentValues to provide the same functionality as before.
|
This is a smart fix, imo. I also had to work around this issue already. (With a less elegant solution.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes time from baseHeaders and RecordRow. This removes the dependency on Unity API in the base class, which allows RecordRow to be called outside the main tread. It also allows for non-time-based Trackers (e.g. frame count or event based). For the provided prototypes MouseScreenTracker, MouseWorldTracker and PositionRotationTracker, the timestamp is added in GetCurrentValues instead of RecordRow to provide the same functionality as before.
This fixes #181