-
Notifications
You must be signed in to change notification settings - Fork 806
Add LICENSE and Copyright Notice #17
Conversation
|
I never filled the
|
|
As a lesser contributor, I don't mind, which ever is easier. |
|
A little late to the conversation, but the Academy license should hold. The work I did on this was under contract for the Academy. Alex Forsythe (aforsythe) should be the point person for that code now. |
|
I would recommend only moving the latest ACES config over to ASWF. Partly because most of the issues you have are with the 0.1.1 and 0.7.1 configs and partly because I don't think those older configs are relevant more than 4 years after the 1.0 release. We should also have a discussion about versioning for the ASWF repo. Rather than creating new directories for each ACES point release, would it make more sense to just have one ACES config and create git tags or branches for different ACES versions? |
We talked about that quite a few times with @aforsythe, and I think it is the way to go. Now that being |
@KelSolaar , if you are working on the 1.1 config, could you provide a brief update on that work? The topic came up in last week's TSC meeting, along with the discussion leading to this draft PR, and issue #18 . I have wondered a time or two if the aces config would be better in its own repo, so it could have independent release versioning specific to aces. Perhaps even in a repo managed by A.M.P.A.S, since it is licensed by A.M.P.A.S. Tags or branches in this repo is another option, but since there are multiple configs besides aces, versioning could be confusing between them. Just a thought. |
|
@michdolan : so I started to look at that last week, the idea as discussed with @aforsythe is for now to not break the house, and I will keep the current structure until I have an effectively working 1.1. It requires a bit of work to include the new
Yes! My answer to that is summarised here in what we wrote in the ACES R.A.E. paper: |
|
I have a 1.1 config here with the SSTS based OTs: https://github.com/colour-science/OpenColorIO-Configs/tree/feature/aces-1.1-config/aces_1.1 It needs to be tested thoroughly but so far seems to be working. Would be good to catch up with all the stakeholders to know how we move forward from this as The Foundry expressed the need for a 1.1 config as soon as. There are also the questions of alternate shapers (#18) and potential definition of both to_reference/from_reference for some difficult colourspaces. Please note that any changes will be done under the Build "ACES 1.1" config. commit to avoid repo size explosion, i.e. I will re-write history of the feature branch as required. |
|
I've created a draft repo structure in my fork: And started a more long-form discussion thread here: |
|
I just remembered that we should clarify with @JGoldstone what is the license for the code he added that implements the Hermite splines. |
|
All good from my end. |
|
Fine by me. |
|
Thanks a lot @alexfry and @selfshadow! |
|
We are OK with this (the Hermite spline function definition and the augmentation of the IDT generator to use it) being released under the Academy license. |
|
Thank you so much @JGoldstone! |
|
Thanks all! I'm closing this PR since another will be opened from https://github.com/colour-science/OpenColorIO-Configs to update the ACES config license. |
This is a DRAFT PR, intended for initial review and discussion.
Many source files in this repo have no license or copyright notice. In preparation for moving the repo to the ASWF GitHub account, we need to add the correct notice. In config sub-directories with no notice, I have added the recommended SPDX notice as outlined here:
https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#copyright-notice-format
The three latest aces config directories do carry an existing copyright attributed to "ACES Developers". That needs to remain intact, but the related license entry is blank. I would assume that implies the OCIO BSD-3-Clause license, in which case the standard SPDX header comment could be added (but not the OCIO copyright statement). Along with that, my thought is to also change:
__license__ == ''to
__license__ == 'BSD-3-Clause'That is a bit of a legal gray area to me though, so I have not touched these files yet. Sage OSS legal wisdom is appreciated here as we determine how best to proceed.
I have also added an initial LICENSE file to the repo, which currently includes both the standard OCIO statement for the work overall, and the ACES Developers statement for the three aces configs.