Skip to content

Conversation

@prasoon0909
Copy link
Contributor

@prasoon0909 prasoon0909 commented Jul 20, 2023

  1. Removed authentication endpoint from SDK initialisation.
  2. Removed authentication endpoint related logic.
  3. Added security parameters(signature, token and expire) directly to upload method as part of UploadOptions parameter.
  4. Added test case for missing security parameters.
  5. Removed test cases related to authentication endpoint flow test coverage.
  6. Modified test cases to incorporate the changes after removing authentication endpoint flow.
  7. Removed auth endpoint from sample app and moved the generating logic of security parameters inside the base route and passing the security parameters directly to upload method of javascript sdk.

…st cases

- Added a new test case to cover missing security parameters during file upload.
- Updated existing test cases to reflect changes after removing authentication endpoint and related logic.
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% 🎉

Comparison is base (0ac3953) 95.39% compared to head (ade82ed) 95.54%.

❗ Current head ade82ed differs from pull request most recent head 8e40b10. Consider uploading reports for the commit 8e40b10 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   95.39%   95.54%   +0.15%     
==========================================
  Files           9        9              
  Lines         217      202      -15     
  Branches       47       50       +3     
==========================================
- Hits          207      193      -14     
+ Misses          2        1       -1     
  Partials        8        8              
Files Changed Coverage Δ
src/constants/errorMessages.ts 100.00% <ø> (ø)
src/upload/index.ts 97.77% <100.00%> (+0.80%) ⬆️
src/utils/request.ts 97.22% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@imagekitio imagekitio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects readme needs to be updated. Please go through the whole readme.md, there are multiple places which would require change. Also bump the version, we have to release a major version because it will be breaking. Do mention about this breaking change at the top.
image

@imagekitio imagekitio merged commit dde854f into imagekit-developer:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants