v5 does not unset PG* environment variables

[bkoelman]

The release notes for v5 mention that it unsets PG* environment variables. I've tried this on Windows. It turns out the variables are set to an empty string instead of being unset.

After running your action, the next powershell script:

Get-ChildItem env:* | Sort-Object Name | Format-List

includes the following entries:

As a result, 3rd party libs/tools that check for the existence of the variable and use it when present won't work properly.

Is there a way to truly unset them, instead of setting them to an empty string?

[ikalnytskyi]

Unfortunately, GitHub Actions doesn't support unsetting environment variables. The best we can do in this case is to set those we don't need to nullify their values to avoid any confusion (e.g. when PGUSER is set to a wrong value).

The Usage section in README now contains a note that warns users that they are recommended to use the connection-uri output parameter or PGSERVICE=postgres environment variable.

I'm sorry, I don't think I can do more at the moment. As I mentioned in the previous issue, I deliberately don't want to set PGUSER, PGPASSWORD and other environment variables. I want consumers to be explicit about PostgreSQL users they want to use, and using connection-uri output parameter of PGSERVICE is easy enough in order to do not decline user experience.

[bkoelman]

Thanks for looking into this. It's good to know that there's no better way, so the current behavior makes sense.

I don't understand why you're against setting PGUSER/PGPASSWORD. There are many systems out there that consume them. What's wrong with facilitating that?