Skip to content

Conversation

@dyst5422
Copy link

Allowing for render props. This should simplify a lot of the issues people have using refs.

Example usage:

<NotificationSystem>
  {({ addNotification }) => (
    <button onClick={() => addNotification({ message: 'New notification' })}>Add Notification</button>
  )}
</NotificationSystem>

@coveralls
Copy link

Coverage Status

Coverage decreased (-79.04%) to 16.544% when pulling ef74578 on dyst5422:master into e2c4a14 on igorprado:master.

@dyst5422
Copy link
Author

Very confused as to why the coverage went down. I just added a single test for the render props and changed nothing else

@dyst5422
Copy link
Author

@igorprado Can I get some feedback on making this one happen?

@syndbg
Copy link
Collaborator

syndbg commented Jun 18, 2018

@dyst5422 Will get back to you.

@syndbg syndbg self-requested a review June 18, 2018 16:19
@dyst5422
Copy link
Author

Any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants