Sync upstream

[iamwavecut]

PR Type

Enhancement

---

Description

• Major refactoring of quicktype codebase with comprehensive language renderer implementations
• Added complete C++ renderer with full code generation, type mapping, and JSON serialization support
• Implemented new Swift renderer with Codable protocol support and Alamofire integration
• Added Ruby renderer using Dry::Struct and Dry::Types with JSON validation
• Created new JSON Schema target language implementation
• Enhanced GraphQL input module with improved type safety and error handling
• Refactored core modules (ConvenienceRenderer, Transformers, GatherNames) with better TypeScript patterns
• Added Smithy4s language support with constants and reserved keywords
• Reorganized imports across codebase with alphabetical ordering and type-only imports
• Improved type safety throughout with proper generic constraints and readonly modifiers
• Deleted legacy language files and moved to modular renderer structure

---

Changes walkthrough 📝

	Relevant files
Enhancement	10 files CPlusPlusRenderer.ts Complete C++ renderer implementation with full code generation packages/quicktype-core/src/language/CPlusPlus/CPlusPlusRenderer.ts • Complete implementation of C++ code generator with 3467 lines of new code • Added comprehensive type mapping, class generation, enum handling, and JSON serialization • Implemented optional types, unions, constraints, and helper functions • Added support for both single-file and multi-file output structures +1402/-1051 index.ts GraphQL input module refactoring and type improvements      packages/quicktype-graphql-input/src/index.ts • Updated import statements and type definitions for better organization • Reordered interface properties and added proper type annotations • Improved code formatting and added missing type safety features • Enhanced error handling and null safety checks +270/-120 language.ts New JSON Schema target language implementation                      packages/quicktype-core/src/language/JSONSchema/language.ts • Added new JSON Schema target language implementation • Implemented language configuration with display name and file extension • Added renderer factory method and language-specific options • Configured string type mapping and object type support +46/-0    JSONSchemaInput.ts Major refactoring of JSON Schema input processing with improved type safety packages/quicktype-core/src/input/JSONSchemaInput.ts • Reorganized imports with alphabetical sorting and added biome-ignore comment • Moved PathElement and PathElementKind types to separate module • Refactored path element comparison logic with explicit type checking • Updated function signatures to use proper TypeScript types and readonly arrays • Replaced regex literal with more concise syntax and improved URI handling • Enhanced error handling and type safety throughout the file +725/-321 ConvenienceRenderer.ts Enhanced convenience renderer with improved comment handling and type safety packages/quicktype-core/src/ConvenienceRenderer.ts • Reorganized imports and updated import paths for type definitions • Added comprehensive comment handling functionality with emitComments method • Enhanced type definitions with proper interfaces and readonly modifiers • Improved function signatures with better parameter typing and return types • Updated method implementations with more explicit type checking and error handling +587/-210 GatherNames.ts Improved type safety and import organization in name gathering packages/quicktype-core/src/GatherNames.ts • Reorganized imports and updated import paths for type definitions • Enhanced type annotations with proper generic constraints and readonly modifiers • Improved function parameter typing and return type specifications • Added better type safety checks and explicit type assertions throughout +127/-47 constants.ts New constants file for Smithy4s language support                  packages/quicktype-core/src/language/Smithy4s/constants.ts • Added new constants file defining invalid symbols and reserved keywords • Exported arrays of symbols that need special handling in Smithy4s code generation • Included comprehensive list of Scala/Smithy4s reserved words and type names +77/-0    Transformers.ts Refactor Transformers with improved TypeScript patterns and imports packages/quicktype-core/src/Transformers.ts • Reorganized imports to use alphabetical ordering and type-only imports • Added explicit public access modifiers to all class methods and properties • Improved method parameter formatting with better line breaks and trailing commas • Enhanced type annotations with generic constraints and stricter typing • Updated import paths to use new modular structure (Type/TypeGraph, Type/TypeRef) +535/-284 SwiftRenderer.ts Add complete Swift language renderer implementation            packages/quicktype-core/src/language/Swift/SwiftRenderer.ts • Added complete Swift code generation renderer with support for classes, enums, and unions • Implemented Codable protocol support with custom encoding/decoding logic • Added convenience initializers, Alamofire integration, and multi-file output support • Included comprehensive type mapping from quicktype types to Swift types +1550/-0 RubyRenderer.ts Add complete Ruby language renderer implementation              packages/quicktype-core/src/language/Ruby/RubyRenderer.ts • Added complete Ruby code generation renderer using Dry::Struct and Dry::Types • Implemented JSON parsing and serialization with proper type validation • Added support for classes, enums, unions with dynamic type conversion • Included module namespacing and configurable strictness levels +921/-0
Additional files	101 files .deepsource.toml +0/-7      bug_report.md +56/-0    config.yml +5/-0      feature_request.md +40/-0    pull_request_template.md +29/-0    master.yaml +4/-1      action.yaml +1/-1      test-pr.yaml +22/-10  .nvmrc +1/-1      .prettierrc +0/-1      launch.json +38/-38  settings.json +38/-24  tasks.json +0/-15    PACKAGES.md +0/-36    README.md +5/-9      biome.json +16/-0    CustomRenderer.md +145/-0  package.json +31/-20  env.sh +14/-0    package.json +23/-19  Annotation.ts +4/-3      CycleBreaker.ts +15/-5    DateTime.ts +11/-6    DeclarationIR.ts +41/-15  Graph.ts +60/-20  GraphRewriting.ts +406/-156 Inference.ts +97/-0    MakeTransformations.ts +264/-101 MarkovChain.ts +40/-14  Messages.ts +173/-73 Naming.ts +188/-86 Renderer.ts +142/-70 RendererOptions.ts +0/-185  index.ts +193/-0  types.ts +59/-0    Run.ts +324/-295 Source.ts +81/-32  TargetLanguage.ts +63/-32  ProvenanceTypeAttributeKind.ts +35/-0    TransformedStringType.ts +118/-0  Type.ts +377/-248 TypeBuilder.ts +300/-183 TypeBuilderUtils.ts +37/-0    TypeGraph.ts +526/-0  TypeGraphUtils.ts +165/-0  TypeRef.ts +71/-0    TypeUtils.ts +119/-63 index.ts +7/-0      TypeGraph.ts +0/-561  UnifyClasses.ts +165/-65 UnionBuilder.ts +293/-106 AccessorNames.ts +128/-52 Constraints.ts +75/-42  Description.ts +69/-35  EnumValues.ts +35/-14  StringTypes.ts +104/-53 TypeAttributes.ts +65/-29  TypeNames.ts +135/-67 URIAttributes.ts +43/-19  index.ts +65/-61  CompressedJSON.ts +102/-44 FetchingJSONSchemaStore.ts +10/-5    Inference.ts +225/-73 Inputs.ts +159/-71 JSONSchemaStore.ts +19/-5    PathElement.ts +12/-0    PostmanCollection.ts +53/-15  $fetch.ci.ts +3/-0      $fetch.ts +11/-0    NodeIO.ts +41/-15  buffer-stream.ts +14/-4    index.ts +15/-13  All.ts +79/-48  CJSON.ts +0/-4136 CJSONRenderer.ts +5930/-0 constants.ts +122/-0  index.ts +2/-0      language.ts +169/-0  utils.ts +63/-0    constants.ts +102/-0  index.ts +2/-0      language.ts +150/-0  utils.ts +222/-0  CSharp.ts +0/-2309 CSharpRenderer.ts +551/-0  NewtonSoftCSharpRenderer.ts +1169/-0 SystemTextJsonCSharpRenderer.ts +1316/-0 constants.ts +79/-0    index.ts +9/-0      language.ts +218/-0  utils.ts +164/-0  Crystal.ts +0/-426  CrystalRenderer.ts +242/-0  constants.ts +138/-0  index.ts +2/-0      language.ts +30/-0    utils.ts +72/-0    DartRenderer.ts +447/-350 constants.ts +71/-0    index.ts +2/-0      Additional files not shown

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[mentatbot]

I'm getting to work. See my steps and track my cost here.

• Wake on any new activity.
  _{I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked. Learn more about triggers.}

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 5 🔵🔵🔵🔵🔵

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Type Safety Multiple functions have changed parameter types from 'any' to more specific types, but the implementation may not handle all edge cases properly. The pathElementEquals function logic was restructured and needs validation for correctness. function pathElementEquals(a: PathElement, b: PathElement): boolean { if (a.kind !== b.kind) return false; if (a.kind === PathElementKind.Type && b.kind === PathElementKind.Type) { return a.index === b.index; } if ( a.kind === PathElementKind.KeyOrIndex && b.kind === PathElementKind.KeyOrIndex ) { return a.key === b.key; } return true; } Error Handling The checkJSONSchemaObject and related functions have been refactored with new error handling patterns. The logic for handling different input types and error conditions should be thoroughly tested. function checkJSONSchemaObject( x: unknown, refOrLoc: Ref | (() => Ref), ): StringMap { if (Array.isArray(x)) { return messageError("SchemaArrayIsInvalidSchema", withRef(refOrLoc)); } if (x === null) { return messageError("SchemaNullIsInvalidSchema", withRef(refOrLoc)); } if (typeof x !== "object") { return messageError( "SchemaInvalidJSONSchemaType", withRef(refOrLoc, { type: typeof x }), ); } return x; } function checkJSONSchema(x: unknown, refOrLoc: Ref | (() => Ref)): JSONSchema { if (typeof x === "boolean") return x; return checkJSONSchemaObject(x, refOrLoc); } Breaking Changes The RenderContext interface has changed the leadingComments type from string[] to Comment[], and several method signatures have been modified. This could break existing code that depends on the previous interface. export interface RenderContext { leadingComments?: Comment[]; typeGraph: TypeGraph; }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Security	Replace unsafe magic pointers Using magic values like 0xDEADBEEF as pointers is unsafe and can lead to crashes or security vulnerabilities. Consider using proper null handling or defined constants. packages/quicktype-core/src/language/CJSON/CJSONRenderer.ts [764] -" *)0xDEADBEEF;", +" *)NULL;", [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies the use of a magic number (0xDEADBEEF) as a pointer, which is unsafe and can lead to undefined behavior or crashes. Replacing it with NULL is a critical fix for correctness and security.	High
Possible issue	Add missing error handling case The large enum path doesn't handle the case where no matching enum value is found, which could lead to undefined behavior. Add an else clause to throw an appropriate error when the iterator is not found. packages/quicktype-core/src/language/CPlusPlus/CPlusPlusRenderer.ts [1899-1994] -protected emitEnumFunctions(e: EnumType, enumName: Name): void { - const ourQualifier = this.ourQualifier(false); +this.emitLine( + `auto iter = enumValues.find(j.get<${this._stringType.getType()}>());`, +); +this.emitBlock( + "if (iter != enumValues.end())", + false, + () => { + this.emitLine("x = iter->second;"); + }, +); +this.emitBlock( + "else", + false, + () => { + this.emitLine('throw std::runtime_error("Input JSON does not conform to schema!");'); + }, +); - this.emitBlock( - [ - "inline void from_json(", - this.withConst("json"), - " & j, ", - ourQualifier, - enumName, - " & x)", - ], - false, - () => { - if (this.isLargeEnum(e)) { - this.emitBlock( - [ - "static std::unordered_map<", - this._stringType.getType(), - ", ", - ourQualifier, - enumName, - "> enumValues", - ], - true, - () => { - this.forEachEnumCase( - e, - "none", - (name, jsonName) => { - this.emitLine( - "{", - this._stringType.wrapEncodingChange( - [ourQualifier], - this._stringType.getType(), - this.NarrowString.getType(), - [ - this._stringType.createStringLiteral( - [stringEscape(jsonName)], - ), - ], - ), - ", ", - ourQualifier, - enumName, - "::", - name, - "},", - ); - }, - ); - }, - ); - - this.emitLine( - `auto iter = enumValues.find(j.get<${this._stringType.getType()}>());`, - ); - this.emitBlock( - "if (iter != enumValues.end())", - false, - () => { - this.emitLine("x = iter->second;"); - }, - ); - } else { - let onFirst = true; - this.forEachEnumCase(e, "none", (name, jsonName) => { - const maybeElse = onFirst ? "" : "else "; - this.emitLine( - maybeElse, - "if (j == ", - this._stringType.wrapEncodingChange( - [ourQualifier], - this._stringType.getType(), - this.NarrowString.getType(), - [ - this._stringType.createStringLiteral([ - stringEscape(jsonName), - ]), - ], - ), - ") x = ", - ourQualifier, - enumName, - "::", - name, - ";", - ); - onFirst = false; - }); - this.emitLine( - 'else { throw std::runtime_error("Input JSON does not conform to schema!"); }', - ); - } - }, - ); - [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a missing error handling path in the from_json function for large enums. When an enum value from the JSON input is not found in the enumValues map, the code does nothing, which could lead to uninitialized variable usage or incorrect behavior. Adding an else block to throw an exception makes the function more robust and prevents potential bugs.	Medium
General	Fix TypeScript type errors Multiple instances of @ts-expect-error comments indicate type safety issues that should be resolved. These suppressions can hide real type errors and make the code less maintainable. packages/quicktype-core/src/language/CJSON/CJSONRenderer.ts [810-812] -// @ts-expect-error awaiting refactor -cJSON.items?.cType, +cJSON.items?.cType as string, [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that using @ts-expect-error is bad practice as it suppresses potential type errors and harms maintainability. Proposing to fix the underlying type issue is a significant improvement to code quality and robustness.	Medium
	Address code quality issues The file contains a large amount of code (5930 lines) with disabled ESLint rules and a FIXME comment indicating it needs refactoring. This suggests the code may have quality issues that should be addressed before merging. packages/quicktype-core/src/language/CJSON/CJSONRenderer.ts [1-3] -// FIXME: NEEDS REFACTOR +// TODO: Refactor this file to improve code quality and remove ESLint disables /* eslint-disable @typescript-eslint/no-shadow */ /* eslint-disable @typescript-eslint/naming-convention */ Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly points out that the file is very large and has a FIXME comment indicating a need for refactoring. This is a valid maintainability concern. The proposed code change is minor, but raising awareness of the technical debt is valuable.	Low
	Remove redundant union type parameter The type guard parameter should be Type only since UnionType is already a subtype of Type. Including both creates redundant type checking and potential confusion. packages/quicktype-core/src/language/CPlusPlus/CPlusPlusRenderer.ts [188-190] -private isUnion(t: Type | UnionType): t is UnionType { +private isUnion(t: Type): t is UnionType { return t.kind === "union"; } Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion correctly points out that if UnionType is a subtype of Type, the union Type | UnionType is redundant and can be simplified to just Type. This improves code clarity and adheres to TypeScript best practices.	Low
More

[mentatbot]

Review Summary

This is a substantial upstream sync that brings quicktype-bin up to date with quicktype v23.2.0. I've tested the core functionality and the changes appear to work correctly.

✅ What's Working Well

• Build Success: The project builds successfully with all dependencies
• Core Functionality: Tested TypeScript, Python, and Elixir generation - all work correctly
• New Features: Elixir language support is working as expected
• Major Updates: Successfully upgraded from Node 18 → 22, TypeScript 4.9 → 5.8

⚠️ Areas of Concern

Security Vulnerabilities (16 total: 1 low, 5 moderate, 10 high):

• node-fetch < 2.6.7 - forwards secure headers to untrusted sites (HIGH, no fix available)
• merge < 2.1.1 - Prototype Pollution vulnerability (HIGH)
• tar-fs - Path Traversal vulnerabilities (HIGH)

Code Quality Issues:

• Magic pointer value 0xDEADBEEF instead of NULL in C++ renderer (security risk)
• Missing error handling in enum functions could cause undefined behavior
• Large files with disabled ESLint rules and @ts-expect-error suppressions

🔧 Recommendations

1. Address Security Vulnerabilities: Run npm audit fix to resolve fixable issues
2. Fix Code Safety Issues: Replace magic pointer values and add missing error handling
3. Consider Dependency Updates: The node-fetch vulnerability has no automatic fix - may need manual dependency updates

📊 Test Results

• ✅ Build completed successfully
• ✅ TypeScript generation working
• ✅ Python generation working
• ✅ New Elixir language working
• ⚠️ Full test suite requires Maven (not available in this environment)

This appears to be a legitimate upstream sync with substantial improvements. The security vulnerabilities are concerning but appear to be inherited dependency issues rather than new problems introduced by this PR.