Skip to content

Fix CI test jobs fail to detect build failure #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Jun 11, 2024
Merged

Fix CI test jobs fail to detect build failure #181

merged 50 commits into from
Jun 11, 2024

Conversation

@yyyyaaa
Copy link
Contributor

@yyyyaaa yyyyaaa commented Jun 5, 2024 •
edited
Loading

  • fix CI tests: move the old workflow trigger to only run in main, added new workflow to trigger on every PR change
  • fix examples not runnable due to duplicated versions of react, which conflicts with nextjs
  • Some weird TS issues
  • Fixed layout issues in some examples

@yyyyaaa yyyyaaa force-pushed the fix/ci-fail-to-detect branch from 893eaff to c54c5f5 Compare June 7, 2024 02:49
@yyyyaaa yyyyaaa force-pushed the fix/ci-fail-to-detect branch from c54c5f5 to 682e44f Compare June 7, 2024 02:50
@yyyyaaa yyyyaaa changed the title (WIP) Fix CI test jobs failed to detect build failure Fix CI test jobs fail to detect build failure Jun 8, 2024
@yyyyaaa yyyyaaa requested a review from pyramation June 8, 2024 00:23
@pyramation pyramation merged commit 9867885 into main Jun 11, 2024
pyramation added a commit that referenced this pull request Aug 28, 2024
@pyramation
Merge pull request #181 from cosmology-tech/fix/ci-fail-to-detect
badedf6 
Fix CI test jobs fail to detect build failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyramation pyramation Awaiting requested review from pyramation

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yyyyaaa @pyramation