Skip to content

trino request handler fix for exception message length #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

satish-mittal
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@satish-mittal satish-mittal requested a review from a team as a code owner October 25, 2023 16:56
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #211 (cb03283) into main (40fc51e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #211      +/-   ##
============================================
+ Coverage     72.70%   72.71%   +0.01%     
  Complexity     1091     1091              
============================================
  Files            96       96              
  Lines          4781     4780       -1     
  Branches        551      550       -1     
============================================
  Hits           3476     3476              
+ Misses         1081     1080       -1     
  Partials        224      224              
Flag Coverage Δ
integration 72.71% <0.00%> (+0.01%) ⬆️
unit 68.67% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../query/service/trino/TrinoBasedRequestHandler.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@satish-mittal satish-mittal merged commit 0204dde into main Oct 26, 2023
@satish-mittal satish-mittal deleted the trino_exception_truncate branch October 26, 2023 05:48
@github-actions
Copy link

Unit Test Results

  40 files  ±0    40 suites  ±0   10s ⏱️ -2s
303 tests ±0  303 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0204dde. ± Comparison against base commit 40fc51e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants