Skip to content

feat: using latest ubuntu runners #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

feat: using latest ubuntu runners #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13cdd0a
upgrading ubuntu runner to latest
thugrock7 Apr 22, 2025
36ff4f7
updating to use java 11 adoption
thugrock7 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-springboot-smoke-dist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,5 @@ jobs:
./gradlew jib -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain --stacktrace -Ptag=$TAG
./gradlew jib -PtargetJDK=15 -Djib.httpTimeout=120000 -Djib.console=plain --stacktrace -Ptag=$TAG
working-directory: smoke-tests/springboot
env:
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these java options for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --add-opens flags were added because Java 17 (default in ubuntu-latest) strictly blocks reflection access that was permitted in Java 11.
Ref actions: https://github.com/hypertrace/javaagent/actions/runs/14587461988/job/40915439308
To solve InaccessibleObjectException observed, explicitly granting permission to use reflection on Java's internal classes of java.util and java.io packages

7 changes: 5 additions & 2 deletions .github/workflows/build-test-matrix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Set up JDK 11 for running Gradle
uses: actions/setup-java@v1
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: Cache gradle dependencies
Expand All @@ -34,4 +35,6 @@ jobs:
TAG="$(date '+%Y%m%d').$GITHUB_RUN_ID"
echo "Using extra tag $TAG"
./gradlew buildMatrix pushMatrix -PextraTag=$TAG
working-directory: smoke-tests/matrix
working-directory: smoke-tests/matrix
env:
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
22 changes: 17 additions & 5 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
# Set fetch-depth: 0 to fetch commit history and tags for use in version calculation
- name: Check out code
Expand All @@ -21,6 +21,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: Set up JDK 11
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

Expand All @@ -37,10 +43,10 @@ jobs:
- name: build
run: make build
env:
JVM_OPTS: -Xmx1g
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
TERM: dumb
muzzle:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/[email protected]
Expand All @@ -50,6 +56,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: Set up JDK 11
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

Expand All @@ -66,12 +78,12 @@ jobs:
- name: muzzle
run: make muzzle
env:
JVM_OPTS: -Xmx1g
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
TERM: dumb

#TODO
# dependency-check:
# runs-on: ubuntu-20.04
# runs-on: ubuntu-latest
# steps:
# - name: Check out code
# uses: actions/[email protected]
Expand Down
30 changes: 24 additions & 6 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

jobs:
test:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
# Set fetch-depth: 0 to fetch commit history and tags for use in version calculation
- name: Check out code
Expand All @@ -14,6 +14,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: Set up JDK 11
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

Expand All @@ -30,11 +36,11 @@ jobs:
- name: build
run: make build
env:
JVM_OPTS: -Xmx1g
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
TERM: dumb

smoke-test:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
matrix:
suite: [ "glassfish", "jetty", "liberty", "tomcat", "tomee", "wildfly", "other" ]
Expand All @@ -47,6 +53,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: Set up JDK 11
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

Expand All @@ -63,12 +75,12 @@ jobs:
- name: smoke-test
run: make smoke-test SMOKE_TEST_SUITE=${{ matrix.suite }}
env:
JVM_OPTS: -Xmx1g
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
TERM: dumb

release:
needs: [ test, smoke-test ]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
# Set fetch-depth: 0 to fetch commit history and tags for use in version calculation
- name: Check out code
Expand All @@ -77,6 +89,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: Set up JDK 11
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

Expand All @@ -96,7 +114,7 @@ jobs:
ORG_GRADLE_PROJECT_signingKey=$(echo $SIGNING_KEY | base64 -d) ./gradlew publish
./gradlew closeAndReleaseRepository
env:
JVM_OPTS: -Xmx1g
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED
TERM: dumb
ORG_GRADLE_PROJECT_ossrhUsername: ${{ secrets.ORG_GRADLE_PROJECT_OSSRHUSERNAME }}
ORG_GRADLE_PROJECT_ossrhPassword: ${{ secrets.ORG_GRADLE_PROJECT_OSSRHPASSWORD }}
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/smoke-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
smoke-test:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
matrix:
suite: [ "glassfish", "jetty", "liberty", "tomcat", "tomee", "wildfly", "other" ]
Expand All @@ -25,6 +25,12 @@ jobs:
fetch-depth: 0
submodules: true

- name: Set up JDK 11
uses: actions/setup-java@v2
with:
distribution: adopt
java-version: 11

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

Expand All @@ -41,5 +47,5 @@ jobs:
- name: smoke-test
run: make smoke-test SMOKE_TEST_SUITE=${{ matrix.suite }}
env:
JVM_OPTS: -Xmx1g
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
TERM: dumb
Loading