Skip to content

✨ Expose reporting config to consumers of javaagent-core so that Filter implementation authors can access them #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 28, 2021

Conversation

ryandens
Copy link
Member

@ryandens ryandens commented Jun 28, 2021

Description

Allow the HypertraceConfig APIs around reporting and OPA configuration to be exposed to clients following a similar pattern as done with the InstrumentationConfig. PR #322 moved the config implementation out of the javaagent-core package, but some implementations of the Hypertrace Filter API need to access config properties that are not accessible via the InstrumentationConfig object. As this is a public API, I wanted to make it well known that the ReportingConfig.Opa object isn't going to live forever in this repo, as we'd like to eventually remove configuraton options that are intended for use by Traceable to not be included in the Hypertrace repo.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

N/A

@ryandens ryandens requested a review from pavolloffay June 28, 2021 20:29
@ryandens
Copy link
Member Author

@pavolloffay I know you have lots of context and perspective on this (re: #322 ) let me know if you have any concerns/feedback!

@ryandens ryandens marked this pull request as ready for review June 28, 2021 21:28
@ryandens ryandens merged commit 9a40dc5 into main Jun 28, 2021
@ryandens ryandens deleted the reporting-config branch June 28, 2021 21:44
@pavolloffay
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants