Skip to content

handle .scope postfix when parsing cgroup #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

davexroth
Copy link
Contributor

Description

While parsing /proc/self/cgroup to obtain the containerId, it's possible there is a .scope postfix, such as crio-736665661f3cf3ec691b2feeb2a1ec78918c0ef65381160bbb04f4c298169679.scope which breaks our current parser.

Testing

Tested in openshift and gke clusters

Checklist:

  • [X ] My changes generate no new warnings
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] Any dependent changes have been merged and published in downstream modules

@pavolloffay pavolloffay merged commit c1c40f4 into main Feb 14, 2021
@pavolloffay pavolloffay deleted the scoped_container_id branch February 14, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants