Update config to use filter jar paths and load jars #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add abstract client tests (hypertrace#246)
Pull hypertrace main
publishing filter-api (hypertrace#252)
…ad these jars in FilterRegistry
pavolloffay
reviewed
Feb 10, 2021
javaagent-core/src/test/java/org/hypertrace/agent/core/config/HypertraceConfigTest.java
Outdated
Show resolved
Hide resolved
javaagent-core/src/main/java/org/hypertrace/agent/core/config/HypertraceConfig.java
Outdated
Show resolved
Hide resolved
filter-api/src/main/java/org/hypertrace/agent/filter/FilterRegistry.java
Outdated
Show resolved
Hide resolved
| System.out.println(jarPath.getValue()); | ||
| files.add(file); | ||
| }); | ||
| int i = 0; |
filter-api/src/main/java/org/hypertrace/agent/filter/FilterRegistry.java
Show resolved
Hide resolved
filter-api/src/main/java/org/hypertrace/agent/filter/FilterRegistry.java
Outdated
Show resolved
Hide resolved
pavolloffay
reviewed
Feb 10, 2021
| implementation("org.slf4j:log4j-over-slf4j:1.7.30") | ||
| implementation("org.slf4j:jcl-over-slf4j:1.7.30") | ||
| implementation("org.slf4j:jul-to-slf4j:1.7.30") | ||
| implementation("org.slf4j:log4j-over-slf4j:${versions["slf4j"]}") |
| int i = 0; | ||
| for (StringValue jarPath : jarPaths) { | ||
| try { | ||
| URL url = new URL("file", "", -1, jarPath.getValue()); |
There was a problem hiding this comment.
Do we know that this works on Windows?
There was a problem hiding this comment.
No.. I am not sure
pavolloffay
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending: update submodule after hypertrace/agent-config#47 is merged