Skip to content

refactor: add support for trailer building and update deps #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Two parts

  1. Updated dependencies. This involved a hotfix release for jackson databind that resolved a CVE, and adding a new constraint on proto. Although not directly used, its always used in conjunction with grpc so this was the best common place we had to constrain the version.
  2. Added a way to build GRPC trailers from a request context. We already have this conversion as headers in the other direction, but this allows us to propagate things back (in my case, request IDs with errors).

Testing

Added UTs

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #38 (6407d98) into main (1e3ae39) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #38      +/-   ##
============================================
+ Coverage     72.43%   72.87%   +0.43%     
- Complexity      129      131       +2     
============================================
  Files            19       19              
  Lines           370      376       +6     
  Branches         21       21              
============================================
+ Hits            268      274       +6     
  Misses           81       81              
  Partials         21       21              
Flag Coverage Δ
unit 72.87% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ertrace/core/grpcutils/context/RequestContext.java 67.18% <100.00%> (+3.39%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-steinfeld aaron-steinfeld merged commit c9d8b57 into main Oct 18, 2022
@aaron-steinfeld aaron-steinfeld deleted the deps-and-trailers branch October 18, 2022 01:06
@github-actions
Copy link

Unit Test Results

12 files  ±0  12 suites  ±0   16s ⏱️ ±0s
62 tests +1  62 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit c9d8b57. ± Comparison against base commit 1e3ae39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants