Skip to content

Eng 11242 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 2, 2021
Merged

Eng 11242 #98

merged 4 commits into from
Sep 2, 2021

Conversation

kamaleshnneerasa
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.
Mutations for Label Management: Added create, update, delete apis/mutations in graphql for label management.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@kamaleshnneerasa kamaleshnneerasa requested a review from a team as a code owner September 1, 2021 06:25
@github-actions

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

Merging #98 (443ee2a) into main (c1ceb5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #98   +/-   ##
=========================================
  Coverage     22.22%   22.22%           
  Complexity       67       67           
=========================================
  Files            64       64           
  Lines          1615     1615           
  Branches         50       50           
=========================================
  Hits            359      359           
  Misses         1248     1248           
  Partials          8        8
Flag Coverage Δ
unit 22.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ceb5e...443ee2a. Read the comment docs.

skjindal93
skjindal93 reviewed Sep 1, 2021
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@kamaleshnneerasa kamaleshnneerasa merged commit 3549f7c into main Sep 2, 2021
@kamaleshnneerasa kamaleshnneerasa deleted the ENG-11242 branch September 2, 2021 13:18
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Unit Test Results

10 files  ±0  10 suites  ±0   13s ⏱️ -1s
20 tests ±0  20 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3549f7c. ± Comparison against base commit c1ceb5e.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
@singhalprerana
Upgraded grpc and guava versions (#98)
35ca73c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjindal93 skjindal93 skjindal93 left review comments

@aaron-steinfeld aaron-steinfeld aaron-steinfeld approved these changes

@saxenakshitiz saxenakshitiz saxenakshitiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamaleshnneerasa @aaron-steinfeld @skjindal93 @saxenakshitiz