Skip to content

feat: add group limit to explorer api #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Expose optional group limit api parameter for explorer

Testing

Verified behavior E2E

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner March 16, 2021 12:34
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #76 (7a79113) into main (28b7af5) will decrease coverage by 0.39%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #76      +/-   ##
============================================
- Coverage     22.69%   22.29%   -0.40%     
  Complexity       66       66              
============================================
  Files            64       64              
  Lines          1586     1583       -3     
  Branches         49       49              
============================================
- Hits            360      353       -7     
- Misses         1219     1223       +4     
  Partials          7        7              
Flag Coverage Δ Complexity Δ
unit 22.29% <69.23%> (-0.40%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...lorer/dao/GatewayServiceExploreRequestBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lization/GroupByArgumentDeserializationConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...explorer/request/DefaultExploreRequestBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ce/graphql/spaces/dao/ExplorerBackedSpacesDao.java 89.04% <100.00%> (-0.96%) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b7af5...7a79113. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 94bfc30 into main Mar 16, 2021
@aaron-steinfeld aaron-steinfeld deleted the explorer-group-limit branch March 16, 2021 13:51
@github-actions
Copy link

Unit Test Results

10 files  ±0  10 suites  ±0   17s ⏱️ +4s
20 tests ±0  20 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94bfc30. ± Comparison against base commit 28b7af5.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
* refactor: use caching attribute client

* chore: update snyk expiration

* style: spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants