refactor: expose a way of ordering explorer query by interval #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
============================================
- Coverage 28.02% 22.69% -5.33%
- Complexity 48 66 +18
============================================
Files 43 64 +21
Lines 1092 1586 +494
Branches 34 49 +15
============================================
+ Hits 306 360 +54
- Misses 780 1219 +439
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
skjindal93
reviewed
Mar 15, 2021
|
|
||
| private Maybe<OrderByExpression> buildAttributeOrderExpression(ExploreOrderArgument argument) { | ||
| return Maybe.fromOptional(argument.attribute()) | ||
| .doOnComplete(() -> log.error("Attribute order argument missing attribute: {} ", argument)) |
There was a problem hiding this comment.
RxJava has weird operator names. doOnComplete should ideally have been called doOnEmpty
There was a problem hiding this comment.
yeah I had to double check that one - complete == an empty final state, success == a final state with a value.
skjindal93
previously approved these changes
Mar 15, 2021
skjindal93
approved these changes
Mar 15, 2021
This comment has been minimized.
This comment has been minimized.
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the interval field in explorer was first class, the generic ordering argument that accepted a string as key does not support anything beyond the default ordering, which is ascending. Along with hypertrace/gateway-service#82 , this adds support for ordering by interval by passing the name of the interval field
intervalStartwithout otherwise changing the api.Testing
Added UT. Will test e2e before merging
Checklist: