Skip to content

feat: add support for joining entities to other schemas #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

This change makes it easy to join entities to other schemas by simply providing a collection of items to join against and a getter to extract entity IDs from it. Internally, it then optimizes this into parallel queries (one per entity type) and returns a result table mapping the provided item to each entity object.

Testing

Have tested this e2e, will be adding unit tests before merging

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner February 18, 2021 16:07
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #72 (f7ac0fb) into main (4d77f67) will decrease coverage by 28.24%.
The diff coverage is 79.83%.

Impacted file tree graph

@@              Coverage Diff              @@
##               main      #72       +/-   ##
=============================================
- Coverage     56.26%   28.02%   -28.25%     
- Complexity       41       48        +7     
=============================================
  Files            20       43       +23     
  Lines           375     1092      +717     
  Branches         18       34       +16     
=============================================
+ Hits            211      306       +95     
- Misses          160      780      +620     
- Partials          4        6        +2     
Flag Coverage Δ Complexity Δ
unit 28.02% <79.83%> (-28.25%) 0.00 <7.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../hypertrace/graphql/entity/EntitySchemaModule.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...y/deserialization/EntityDeserializationModule.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...hypertrace/graphql/entity/joiner/EntityJoiner.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...race/graphql/entity/joiner/EntityJoinerModule.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...phql/entity/joiner/DefaultEntityJoinerBuilder.java 93.13% <93.13%> (ø) 7.00 <7.00> (?)
...ace/graphql/entity/request/EdgeRequestBuilder.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...ql/entity/dao/GatewayServiceEntityEdgeFetcher.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...rtrace/graphql/entity/dao/InteractionResponse.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...GatewayServiceEntityInteractionRequestBuilder.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d77f67...f7ac0fb. Read the comment docs.

@github-actions

This comment has been minimized.

tim-mwangi
tim-mwangi previously approved these changes Feb 18, 2021
@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit ec389ef into main Feb 19, 2021
@aaron-steinfeld aaron-steinfeld deleted the support-joining-entities branch February 19, 2021 02:34
@github-actions
Copy link

Unit Test Results

  8 files  +1    8 suites  +1   9s ⏱️ -2s
18 tests +3  18 ✔️ +3  0 💤 ±0  0 ❌ ±0 

Results for commit ec389ef. ± Comparison against base commit 4d77f67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants