Skip to content

refactor: update grpc registry, plugins #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Small changes - to change how registry is injected, added a new test to better validate guice config, updated a few plugins.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner September 9, 2022 17:31
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Test Results

25 tests  +1   25 ✔️ +1   18s ⏱️ +5s
11 suites ±0     0 💤 ±0 
11 files   ±0     0 ±0 

Results for commit 742c99f. ± Comparison against base commit 0830119.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #155 (742c99f) into main (0830119) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #155      +/-   ##
============================================
+ Coverage     22.80%   22.84%   +0.04%     
  Complexity       75       75              
============================================
  Files            65       65              
  Lines          1741     1742       +1     
  Branches         53       53              
============================================
+ Hits            397      398       +1     
  Misses         1335     1335              
  Partials          9        9              
Flag Coverage Δ
unit 22.84% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/org/hypertrace/graphql/impl/GraphQlModule.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-steinfeld aaron-steinfeld merged commit bb5afd8 into main Sep 9, 2022
@aaron-steinfeld aaron-steinfeld deleted the registry-changes branch September 9, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants