Skip to content

feat: add parallel querying #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022
Merged

feat: add parallel querying #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helm/templates/serviceconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ data:
graphql.corsEnabled = {{ .Values.serviceConfig.corsEnabled }}
graphql.timeout = {{ .Values.serviceConfig.timeoutDuration }}

threads.io.max = {{ .Values.serviceConfig.threads.io }}
threads.request.max = {{ .Values.serviceConfig.threads.request }}

attribute.service = {
host = {{ .Values.serviceConfig.attributeService.host }}
port = {{ .Values.serviceConfig.attributeService.port }}
Expand Down
3 changes: 3 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ serviceConfig:
corsEnabled: true
defaultTenantId: ""
timeoutDuration: 30s
threads:
io: 10
request: 10
attributeService:
host: attribute-service
port: 9012
Expand Down
2 changes: 1 addition & 1 deletion hypertrace-core-graphql
Open in desktop
Submodule hypertrace-core-graphql updated 12 files
+3 −0 helm/templates/serviceconfig.yaml
+3 −0 helm/values.yaml
+3 −0 hypertrace-core-graphql-context/build.gradle.kts
+63 −0 hypertrace-core-graphql-context/src/main/java/org/hypertrace/core/graphql/context/AsyncDataFetcherFactory.java
+9 −6 ...-graphql-context/src/main/java/org/hypertrace/core/graphql/context/DefaultGraphQlRequestContextBuilder.java
+3 −1 hypertrace-core-graphql-context/src/main/java/org/hypertrace/core/graphql/context/GraphQlRequestContext.java
+40 −0 ...ace-core-graphql-context/src/test/java/org/hypertrace/core/graphql/context/AsyncDataFetcherFactoryTest.java
+9 −6 ...phql-context/src/test/java/org/hypertrace/core/graphql/context/DefaultGraphQlRequestContextBuilderTest.java
+18 −24 hypertrace-core-graphql-platform/build.gradle.kts
+8 −0 ...ace-core-graphql-service/src/main/java/org/hypertrace/core/graphql/service/DefaultGraphQlServiceConfig.java
+1 −0 hypertrace-core-graphql-service/src/main/resources/configs/common/application.conf
+2 −0 hypertrace-core-graphql-spi/src/main/java/org/hypertrace/core/graphql/spi/config/GraphQlServiceConfig.java
3 changes: 3 additions & 0 deletions ...hql-service/src/main/java/org/hypertrace/graphql/service/DefaultGraphQlServiceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class DefaultGraphQlServiceConfig implements HypertraceGraphQlServiceConfig {
private static final String DEFAULT_TENANT_ID = "defaultTenantId";

private static final String MAX_IO_THREADS_PROPERTY = "threads.io.max";
private static final String MAX_REQUEST_THREADS_PROPERTY = "threads.request.max";

private static final String ATTRIBUTE_SERVICE_HOST_PROPERTY = "attribute.service.host";
private static final String ATTRIBUTE_SERVICE_PORT_PROPERTY = "attribute.service.port";
Expand All @@ -46,6 +47,7 @@ class DefaultGraphQlServiceConfig implements HypertraceGraphQlServiceConfig {
Duration graphQlTimeout;
Optional<String> defaultTenantId;
int maxIoThreads;
int maxRequestThreads;
String attributeServiceHost;
int attributeServicePort;
Duration attributeServiceTimeout;
Expand All @@ -67,6 +69,7 @@ class DefaultGraphQlServiceConfig implements HypertraceGraphQlServiceConfig {
this.graphQlTimeout = untypedConfig.getDuration(GRAPHQL_TIMEOUT);
this.defaultTenantId = optionallyGet(() -> untypedConfig.getString(DEFAULT_TENANT_ID));
this.maxIoThreads = untypedConfig.getInt(MAX_IO_THREADS_PROPERTY);
this.maxRequestThreads = untypedConfig.getInt(MAX_REQUEST_THREADS_PROPERTY);

this.attributeServiceHost = untypedConfig.getString(ATTRIBUTE_SERVICE_HOST_PROPERTY);
this.attributeServicePort = untypedConfig.getInt(ATTRIBUTE_SERVICE_PORT_PROPERTY);
Expand Down
1 change: 1 addition & 0 deletions hypertrace-graphql-service/src/main/resources/configs/common/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ graphql.timeout = 30s
defaultTenantId = ${?DEFAULT_TENANT_ID}

threads.io.max = 10
threads.request.max = 10

attribute.service = {
host = localhost
Expand Down