-
Notifications
You must be signed in to change notification settings - Fork 7
make time range optional in explore query #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
============================================
- Coverage 22.81% 22.77% -0.04%
Complexity 75 75
============================================
Files 65 65
Lines 1736 1739 +3
Branches 53 53
============================================
Hits 396 396
- Misses 1331 1334 +3
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rtrace/hypertrace-graphql into make_time_rang_optional_in_explorer
This comment has been minimized.
This comment has been minimized.
.ifPresent( | ||
timeRangeArgument -> { | ||
builder.setStartTimeMillis(timeRangeArgument.startTime().toEpochMilli()); | ||
builder.setEndTimeMillis(timeRangeArgument.startTime().toEpochMilli()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be timeRangeArgument.endTime().toEpochMilli()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow good eye @skjindal93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
timeRangeArgument.endTime().toEpochMilli()
?
Absolutely, thanks for spotting!
#145
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.