make time range optional in explore query #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
============================================
- Coverage 22.81% 22.77% -0.04%
Complexity 75 75
============================================
Files 65 65
Lines 1736 1739 +3
Branches 53 53
============================================
Hits 396 396
- Misses 1331 1334 +3
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
surajpuvvada
previously approved these changes
May 24, 2022
This comment has been minimized.
This comment has been minimized.
…rtrace/hypertrace-graphql into make_time_rang_optional_in_explorer
This comment has been minimized.
This comment has been minimized.
surajpuvvada
approved these changes
May 26, 2022
tim-mwangi
approved these changes
May 26, 2022
skjindal93
reviewed
May 27, 2022
| .ifPresent( | ||
| timeRangeArgument -> { | ||
| builder.setStartTimeMillis(timeRangeArgument.startTime().toEpochMilli()); | ||
| builder.setEndTimeMillis(timeRangeArgument.startTime().toEpochMilli()); |
There was a problem hiding this comment.
Shouldn't this be timeRangeArgument.endTime().toEpochMilli()?
There was a problem hiding this comment.
Wow good eye @skjindal93
There was a problem hiding this comment.
Shouldn't this be
timeRangeArgument.endTime().toEpochMilli()?
Absolutely, thanks for spotting!
#145
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.