Skip to content

make time range optional in explore query #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2022

Conversation

d-trace
Copy link
Contributor

@d-trace d-trace commented May 24, 2022

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@d-trace d-trace requested a review from skjindal93 May 24, 2022 00:35
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #143 (b83ddb7) into main (f6c5b03) will decrease coverage by 0.03%.
The diff coverage is 8.00%.

@@             Coverage Diff              @@
##               main     #143      +/-   ##
============================================
- Coverage     22.81%   22.77%   -0.04%     
  Complexity       75       75              
============================================
  Files            65       65              
  Lines          1736     1739       +3     
  Branches         53       53              
============================================
  Hits            396      396              
- Misses         1331     1334       +3     
  Partials          9        9              
Flag Coverage Δ
unit 22.77% <8.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lorer/dao/GatewayServiceExploreRequestBuilder.java 0.00% <0.00%> (ø)
...explorer/request/DefaultExploreRequestBuilder.java 0.00% <0.00%> (ø)
...ce/graphql/spaces/dao/ExplorerBackedSpacesDao.java 89.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c5b03...b83ddb7. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

surajpuvvada
surajpuvvada previously approved these changes May 24, 2022
@github-actions

This comment has been minimized.

Copy link

@anandtiwary anandtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

d-trace added 2 commits May 26, 2022 14:13
…rtrace/hypertrace-graphql into make_time_rang_optional_in_explorer
@d-trace d-trace marked this pull request as ready for review May 26, 2022 21:15
@d-trace d-trace requested a review from a team as a code owner May 26, 2022 21:15
@github-actions

This comment has been minimized.

@d-trace d-trace merged commit eff5a7d into main May 26, 2022
@d-trace d-trace deleted the make_time_rang_optional_in_explorer branch May 26, 2022 23:12
@github-actions
Copy link

Unit Test Results

11 files  ±0  11 suites  ±0   14s ⏱️ ±0s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit eff5a7d. ± Comparison against base commit f6c5b03.

.ifPresent(
timeRangeArgument -> {
builder.setStartTimeMillis(timeRangeArgument.startTime().toEpochMilli());
builder.setEndTimeMillis(timeRangeArgument.startTime().toEpochMilli());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be timeRangeArgument.endTime().toEpochMilli()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good eye @skjindal93

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be timeRangeArgument.endTime().toEpochMilli()?

Absolutely, thanks for spotting!
#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants